View Issue Details

IDProjectCategoryView StatusLast Update
0002304ardourfeaturespublic2012-01-10 17:58
Reportercolinf Assigned Topaul  
PrioritynormalSeveritytweakReproducibilityN/A
Status closedResolutionfixed 
Product VersionSVN/2.0-ongoing 
Summary0002304: Meter point changes should reset peak values
DescriptionI think that it arguably makes sense to reset the peak value displayed above the meters whenever the meter point changes between pre, post, & input.

Then when I record-enable a track, I don't have to remember to reset the peak as well to know what that take peaked at. Also, it seems more rational that the peak displayed relates to the signal that's currently showing on the meter.
Additional InformationAttached the (pretty trivial) patch to make it so, if anyone wants...
TagsNo tags attached.

Activities

2008-06-18 15:29

 

reset-peaks-on-meter-point-change.patch (352 bytes)   
Index: gtk2_ardour/mixer_strip.cc
===================================================================
--- gtk2_ardour/mixer_strip.cc	(revision 3470)
+++ gtk2_ardour/mixer_strip.cc	(working copy)
@@ -1228,6 +1228,8 @@
 		}
 
 		gpm.setup_meters ();
+		// reset peak when meter point changes
+		gpm.reset_peak_display();
 		set_width(_width, this);
 }
 

paul

2008-06-18 16:19

administrator   ~0005045

applied and committed, thanks.

colinf

2012-01-10 17:58

updater   ~0012534

Closing my old issues: this is long since fixed.

Issue History

Date Modified Username Field Change
2008-06-18 15:29 colinf New Issue
2008-06-18 15:29 colinf File Added: reset-peaks-on-meter-point-change.patch
2008-06-18 16:19 paul cost => 0.00
2008-06-18 16:19 paul Status new => resolved
2008-06-18 16:19 paul Resolution open => fixed
2008-06-18 16:19 paul Assigned To => paul
2008-06-18 16:19 paul Note Added: 0005045
2012-01-10 17:58 colinf Note Added: 0012534
2012-01-10 17:58 colinf Status resolved => closed