View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002267 | ardour | features | public | 2008-05-23 16:35 | 2012-01-10 17:55 |
| Reporter | colinf | Assigned To | paul | ||
| Priority | normal | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002267: Some UI elements are practically invisible in the light theme | ||||
| Description | There are some user interface elements whose background and foreground colours are very close when the light theme is in use, e.g. the track names on record-enabled tracks and the selected item in pop-up menus. | ||||
| Tags | faders | ||||
|
2008-07-07 17:50
|
light-theme-prelight.patch (476 bytes)
Index: gtk2_ardour/ardour2_ui_light.rc.in
===================================================================
--- gtk2_ardour/ardour2_ui_light.rc.in (revision 3517)
+++ gtk2_ardour/ardour2_ui_light.rc.in (working copy)
@@ -95,7 +95,7 @@
fg[NORMAL] = { 0.30, 0.30, 0.40 }
fg[ACTIVE] = { 0.30, 0.30, 0.40 }
- fg[PRELIGHT] = { 1.0, 1.0, 1.0 }
+ fg[PRELIGHT] = { 0.10, 0.10, 0.20 }
fg[INSENSITIVE] = { 0.30, 0.30, 0.40 }
fg[SELECTED] = { 0.30, 0.30, 0.40 }
|
|
2008-07-08 14:00
|
context-menu-set-name.patch (846 bytes)
Index: gtk2_ardour/plugin_selector.cc
===================================================================
--- gtk2_ardour/plugin_selector.cc (revision 3502)
+++ gtk2_ardour/plugin_selector.cc (working copy)
@@ -491,10 +491,12 @@
if (!_menu) {
_menu = new Menu();
+ _menu->set_name("ArdourContextMenu");
}
MenuList& items = _menu->items();
Menu* favs = new Menu();
+ favs->set_name("ArdourContextMenu");
items.clear ();
items.push_back (MenuElem (_("Favorites"), *favs));
@@ -539,6 +541,7 @@
submenu = new Gtk::Menu;
items.push_back (MenuElem (creator, *submenu));
submenu_map.insert (pair<Glib::ustring,Menu*> (creator, submenu));
+ submenu->set_name("ArdourContextMenu");
}
submenu->items().push_back (MenuElem ((*i)->name, (bind (mem_fun (*this, &PluginSelector::plugin_chosen_from_menu), *i))));
|
|
|
The first of these two patches sets the pre-light colour to dark blueish grey instead of white: this in itself is enough to make selected menu items legible. The second, for the sake of consistency, makes all the pop-up menus use the pop-up menu appearance: at the moment, some do & some don't. I'm still searching for what to change to make track names of record-enabled tracks legible... |
|
|
nice tight patching. applied and committed. thanks! |
|
|
And this works for me to make the names of record-enabled tracks legible: --- gtk2_ardour/ardour2_ui_light.rc.in (revision 3584) +++ gtk2_ardour/ardour2_ui_light.rc.in (working copy) @@ -797,6 +797,7 @@ font_name = "%FONT_NORMAL%" fg[NORMAL] = { 0.80, 0.80, 0.80 } fg[ACTIVE] = { 0.80, 0.80, 0.80 } + text[INSENSITIVE] = { 0.70, 0.70, 0.70 } base[NORMAL] = { 0.80, 0.80, 0.80 } base[ACTIVE] = { 0.80, 0.80, 0.80 } |
|
|
Not certain, did the last changes submitted by Colin ever make it in or not? Can either Colin or Paul confirm or deny so I know whether I can resolve the issue or not? Thanks. Seablade |
|
|
No, the patch in comment 0005106 wasn't applied. |
|
|
Ok waiting on Paul to review it then before I do anything else, thanks. Seablade |
|
|
both patches applied and committed. will be in 2.7.1 |
|
|
Closing my old issues: this is long since fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-05-23 16:35 | colinf | New Issue | |
| 2008-07-07 17:50 | colinf | File Added: light-theme-prelight.patch | |
| 2008-07-08 14:00 | colinf | File Added: context-menu-set-name.patch | |
| 2008-07-09 10:16 | colinf | Note Added: 0005102 | |
| 2008-07-09 18:36 | paul | cost | => 0.00 |
| 2008-07-09 18:36 | paul | Status | new => resolved |
| 2008-07-09 18:36 | paul | Resolution | open => fixed |
| 2008-07-09 18:36 | paul | Assigned To | => paul |
| 2008-07-09 18:36 | paul | Note Added: 0005104 | |
| 2008-07-10 23:08 | colinf | Status | resolved => feedback |
| 2008-07-10 23:08 | colinf | Resolution | fixed => reopened |
| 2008-07-10 23:08 | colinf | Note Added: 0005106 | |
| 2008-12-03 06:26 | seablade | Note Added: 0005464 | |
| 2008-12-03 11:49 | colinf | Note Added: 0005468 | |
| 2008-12-03 19:11 | seablade | Note Added: 0005476 | |
| 2008-12-03 19:11 | seablade | Status | feedback => assigned |
| 2008-12-05 08:26 | paul | Status | assigned => resolved |
| 2008-12-05 08:26 | paul | Resolution | reopened => fixed |
| 2008-12-05 08:26 | paul | Note Added: 0005494 | |
| 2011-02-06 14:14 | luh2112 | Tag Attached: faders | |
| 2012-01-10 17:55 | colinf | Note Added: 0012530 | |
| 2012-01-10 17:55 | colinf | Status | resolved => closed |
