View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0002187 | ardour | bugs | public | 2008-04-09 14:01 | 2012-01-10 17:58 |
| Reporter | colinf | Assigned To | paul | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | SVN/2.0-ongoing | ||||
| Summary | 0002187: Rhythm Ferret 'Split region' is not undoable | ||||
| Description | Rhythm Ferret 'Split region' does not show up as an undoable action. There's a call to session->begin_reversible_command() before doing the splits, but no corresponding call to session->commit_reversible_command() after. | ||||
| Additional Information | Trivial patch attached, which seems to work for me. I don't know whether anything more complex is needed... | ||||
| Tags | No tags attached. | ||||
|
2008-04-09 14:01
|
rhythm-ferret-split-undoable.patch (287 bytes)
Index: gtk2_ardour/rhythm_ferret.cc =================================================================== --- gtk2_ardour/rhythm_ferret.cc (revision 3239) +++ gtk2_ardour/rhythm_ferret.cc (working copy) @@ -277,6 +277,7 @@ i = tmp; } + session->commit_reversible_command (); } |
|
|
applied and committed, thanks. |
|
|
Closing my old issues: this is long since fixed. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2008-04-09 14:01 | colinf | New Issue | |
| 2008-04-09 14:01 | colinf | File Added: rhythm-ferret-split-undoable.patch | |
| 2008-04-21 12:45 | paul | Status | new => resolved |
| 2008-04-21 12:45 | paul | Resolution | open => fixed |
| 2008-04-21 12:45 | paul | Assigned To | => paul |
| 2008-04-21 12:45 | paul | Note Added: 0004883 | |
| 2012-01-10 17:58 | colinf | Note Added: 0012533 | |
| 2012-01-10 17:58 | colinf | Status | resolved => closed |