View Issue Details

IDProjectCategoryView StatusLast Update
0002187ardourbugspublic2012-01-10 17:58
Reportercolinf Assigned Topaul  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product VersionSVN/2.0-ongoing 
Summary0002187: Rhythm Ferret 'Split region' is not undoable
DescriptionRhythm Ferret 'Split region' does not show up as an undoable action.

There's a call to session->begin_reversible_command() before doing the splits, but no corresponding call to session->commit_reversible_command() after.
Additional InformationTrivial patch attached, which seems to work for me. I don't know whether anything more complex is needed...
TagsNo tags attached.

Activities

2008-04-09 14:01

 

rhythm-ferret-split-undoable.patch (287 bytes)   
Index: gtk2_ardour/rhythm_ferret.cc
===================================================================
--- gtk2_ardour/rhythm_ferret.cc	(revision 3239)
+++ gtk2_ardour/rhythm_ferret.cc	(working copy)
@@ -277,6 +277,7 @@
 
 		i = tmp;
 	}
+	session->commit_reversible_command ();
 
 }
 

paul

2008-04-21 12:45

administrator   ~0004883

applied and committed, thanks.

colinf

2012-01-10 17:58

updater   ~0012533

Closing my old issues: this is long since fixed.

Issue History

Date Modified Username Field Change
2008-04-09 14:01 colinf New Issue
2008-04-09 14:01 colinf File Added: rhythm-ferret-split-undoable.patch
2008-04-21 12:45 paul Status new => resolved
2008-04-21 12:45 paul Resolution open => fixed
2008-04-21 12:45 paul Assigned To => paul
2008-04-21 12:45 paul Note Added: 0004883
2012-01-10 17:58 colinf Note Added: 0012533
2012-01-10 17:58 colinf Status resolved => closed