View Issue Details

IDProjectCategoryView StatusLast Update
0001895ardourfeaturespublic2008-11-21 00:04
Reporterlincoln Assigned Tocth103  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Summary0001895: No FreeBoB support in Ardour 2.1 audio setting panel
DescriptionArdour 2.1 seems to have removed support for the FreeBoB driver in the 2.1 release. Also the FFADO driver string passed to the jack command is 'ffado' rather than 'firewire' making the FFADO option unusable.

Since FFADO is experimental I am attaching a patch that re-enables FreeBoB as an option. The FFADO driver string is also corrected.
TagsNo tags attached.

Activities

2007-09-28 21:35

 

ardour_freebob.patch (2,276 bytes)   
Index: gtk2_ardour/engine_dialog.h
===================================================================
--- gtk2_ardour/engine_dialog.h (revision 2499)
+++ gtk2_ardour/engine_dialog.h (working copy)
@@ -93,6 +93,7 @@
        std::vector<std::string> enumerate_oss_devices ();
        std::vector<std::string> enumerate_netjack_devices ();
        std::vector<std::string> enumerate_ffado_devices ();
+       std::vector<std::string> enumerate_freebob_devices ();
        std::vector<std::string> enumerate_dummy_devices ();
 #endif
Index: gtk2_ardour/engine_dialog.cc
===================================================================
--- gtk2_ardour/engine_dialog.cc        (revision 2499)
+++ gtk2_ardour/engine_dialog.cc        (working copy)
@@ -113,6 +113,7 @@
        strings.push_back (X_("ALSA"));
        strings.push_back (X_("OSS"));
        strings.push_back (X_("FFADO"));
+       strings.push_back (X_("FreeBoB"));
 #endif
        strings.push_back (X_("NetJACK"));
        strings.push_back (X_("Dummy"));
@@ -363,6 +364,7 @@
        bool using_coreaudio = false;
        bool using_netjack = false;
        bool using_ffado = false;
+       bool using_freebob = false;
 
        /* first, path to jackd */
 
@@ -424,9 +426,13 @@
                cmd.push_back ("netjack");
        } else if (driver == X_("FFADO")) {
                using_ffado = true;
-               cmd.push_back ("ffado");
+               cmd.push_back ("firewire");
+       } else if (driver == X_("FreeBoB")){
+               using_freebob = true;
+               cmd.push_back ("freebob");
        }
 
+
        /* driver arguments */
 
        if (!using_coreaudio) {
@@ -588,6 +594,7 @@
 #else
        devices["ALSA"] = enumerate_alsa_devices ();
        devices["FFADO"] = enumerate_ffado_devices ();
+       devices["FreeBoB"] = enumerate_freebob_devices();
        devices["OSS"] = enumerate_oss_devices ();
        devices["Dummy"] = enumerate_dummy_devices ();
        devices["NetJACK"] = enumerate_netjack_devices ();
@@ -733,6 +740,12 @@
        return devs;
 }
 vector<string>
+EngineControl::enumerate_freebob_devices ()
+{
+        vector<string> devs;
+               return devs;
+}
+vector<string>
 EngineControl::enumerate_oss_devices ()
 {
        vector<string> devs;
ardour_freebob.patch (2,276 bytes)   

cth103

2007-10-19 13:59

administrator   ~0004484

Hi lincoln,

Many thanks for your patch. I have applied it to trunk, and will check with Paul whether it should also be applied to 2.0-ongoing.

Cheers
Carl

Issue History

Date Modified Username Field Change
2007-09-28 21:35 lincoln New Issue
2007-09-28 21:35 lincoln File Added: ardour_freebob.patch
2007-10-19 13:59 cth103 Status new => resolved
2007-10-19 13:59 cth103 Resolution open => fixed
2007-10-19 13:59 cth103 Assigned To => cth103
2007-10-19 13:59 cth103 Note Added: 0004484
2008-11-21 00:04 seablade Status resolved => closed